Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: example queued_interceptor_csrftoken.dart #2134

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Fix: example queued_interceptor_csrftoken.dart #2134

merged 3 commits into from
Mar 19, 2024

Conversation

seunghwanly
Copy link
Contributor

Provide a more suitable example for queued_interceptor_csrftoken.dart

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

This example adds 2 different QueuedInterceptorsWrapper and the last one handles onError to update csrf token.

fixes #2128

@seunghwanly
fix: queued_interceptor_crsftoken.dart
ffe133c 
newly forked a branch from cfug/dio to test if the test completes as before (100% passed)

cfug#2128 (comment)
@seunghwanly seunghwanly requested a review from a team as a code owner March 13, 2024 04:06
@seunghwanly seunghwanly marked this pull request as draft March 13, 2024 04:11
@seunghwanly
Copy link
Contributor Author

I'll check the type exceptions in test_suite_test.dart

@AlexV525
Copy link
Member

The failing tests should be random, caused by the httpbun, fyi.

AlexV525
AlexV525 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someday we'd expect to have a unit test with token updates.

@seunghwanly seunghwanly marked this pull request as ready for review March 19, 2024 08:40
@seunghwanly
Copy link
Contributor Author

Someday we'd expect to have a unit test with token updates.

I'll also be on the lookout for cases to write unit tests for token refresh.

@AlexV525 AlexV525 added this pull request to the merge queue Mar 19, 2024
Merged via the queue into cfug:main with commit 35533ac Mar 19, 2024
3 checks passed
@seunghwanly seunghwanly deleted the fix-queued-interceptor-csrftoken-example branch December 24, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seunghwanly @AlexV525